sureshanaparti commented on a change in pull request #1878: CLOUDSTACK-9717:
[VMware] RVRs have mismatching MAC addresses for extra public NICs.
URL: https://github.com/apache/cloudstack/pull/1878#discussion_r115658118
##########
File path:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -2072,6 +2121,17 @@ protected StartAnswer execute(StartCommand cmd) {
}
/**
+ * Update boot args with the new nic mac addresses.
+ */
+ protected String replaceNicsMacSequenceInBootArgs(String oldMacSequence,
String newMacSequence, VirtualMachineTO vmSpec) {
+ String bootArgs = vmSpec.getBootArgs();
+ if (!StringUtils.isEmpty(bootArgs) &&
!StringUtils.isEmpty(oldMacSequence) && !StringUtils.isEmpty(newMacSequence)) {
+ return bootArgs.replace(oldMacSequence, newMacSequence);
+ }
+ return "";
Review comment:
@rafaelweingartner May not be possible. `oldMacSequence` and
`newMacSequence` are generated from the NICs info. Both would be empty only
when no NICs are specified for the VM, which will never happen. `bootArgs`
would hold more info including the nics sequence.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
