karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job
framework - Cancelling async jobs
URL: https://github.com/apache/cloudstack/pull/1832#discussion_r115914811
##########
File path: engine/api/src/com/cloud/vm/VirtualMachineManager.java
##########
@@ -108,7 +109,7 @@ void orchestrateStart(String vmUuid,
Map<VirtualMachineProfile.Param, Object> pa
void advanceStop(String vmUuid, boolean cleanupEvenIfUnableToStop) throws
ResourceUnavailableException, OperationTimedoutException,
ConcurrentOperationException;
- void advanceExpunge(String vmUuid) throws ResourceUnavailableException,
OperationTimedoutException, ConcurrentOperationException;
+ void advanceExpunge(String vmUuid) throws ResourceUnavailableException,
OperationTimedoutException, ConcurrentOperationException,
OperationCancelledException;
Review comment:
OperationCancelledException is a checked exception. There will be compiler
errors if its not thrown by the right methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
