karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job
framework - Cancelling async jobs
URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116166622
##########
File path: server/src/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3761,6 +3767,8 @@ public boolean setupVmForPvlan(boolean add, Long hostId,
NicProfile nic) {
} catch (AgentUnavailableException e) {
s_logger.warn("Agent Unavailable ", e);
return false;
+ } catch (OperationCancelledException e) {
Review comment:
it answer is null, false is returned at the end. removed return in the above
exception handling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services