yvsubhash commented on a change in pull request #2102: CLOUDSTACK-9889
Dedication of guest vlan range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#discussion_r117221695
##########
File path:
api/src/org/apache/cloudstack/api/command/admin/network/DedicateGuestVlanRangeCmd.java
##########
@@ -106,14 +107,27 @@ public long getEntityOwnerId() {
@Override
public void execute() throws ResourceUnavailableException,
ResourceAllocationException {
- GuestVlan result = _networkService.dedicateGuestVlanRange(this);
- if (result != null) {
- GuestVlanRangeResponse response =
_responseGenerator.createDedicatedGuestVlanRangeResponse(result);
- response.setResponseName(getCommandName());
- response.setObjectName("dedicatedguestvlanrange");
- this.setResponseObject(response);
- } else {
- throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed
to dedicate guest vlan range");
+ if (projectId == null && (accountName == null ||
accountName.isEmpty()) ) {
Review comment:
@kishankavala
It is taken care inside the method call
Domain d = _domainDao.findById(domainId);
if (d == null) {
throw new InvalidParameterValueException("Please specify a valid
domain");
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
