PranaliM commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860:
Power off VMs when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#discussion_r118468844
##########
File path:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
##########
@@ -4862,10 +4862,15 @@ public synchronized Network setupvSwitchNetwork(final
Connection conn) {
return null;
}
- public void shutdownVM(final Connection conn, final VM vm, final String
vmName) throws XmlRpcException {
+ public void shutdownVM(final Connection conn, final VM vm, final String
vmName, final boolean forcedStop) throws XmlRpcException {
Task task = null;
try {
- task = vm.cleanShutdownAsync(conn);
+ if (forcedStop) {
+ task = vm.hardShutdownAsync(conn);
Review comment:
@rhtyd , If there is an exception in doing a hard-shutdown on the VM, the
logger in 'catch' would still log it as "Unable to cleanShutdown VM". May be
should consider changing the log statement accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
