nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 :
NCC Integration with CloudStack
URL: https://github.com/apache/cloudstack/pull/2031#discussion_r122589635
##########
File path: engine/components-api/src/com/cloud/network/IpAddressManager.java
##########
@@ -162,22 +164,30 @@ void transferPortableIP(long ipAddrId, long
currentNetworkId, long newNetworkId)
* @throws InsufficientAddressCapacityException
*/
PublicIp assignDedicateIpAddress(Account owner, Long guestNtwkId, Long
vpcId, long dcId, boolean isSourceNat) throws ConcurrentOperationException,
- InsufficientAddressCapacityException;
+ InsufficientAddressCapacityException;
IpAddress allocateIp(Account ipOwner, boolean isSystem, Account caller,
long callerId, DataCenter zone, Boolean displayIp) throws
ConcurrentOperationException,
- ResourceAllocationException, InsufficientAddressCapacityException;
+ ResourceAllocationException, InsufficientAddressCapacityException;
+
PublicIp assignPublicIpAddressFromVlans(long dcId, Long podId, Account
owner, VlanType type, List<Long> vlanDbIds, Long networkId, String requestedIp,
- boolean isSystem) throws InsufficientAddressCapacityException;
+ boolean isSystem) throws InsufficientAddressCapacityException;
@DB
void allocateNicValues(NicProfile nic, DataCenter dc,
VirtualMachineProfile vm, Network network, String requestedIpv4,
- String requestedIpv6) throws
InsufficientVirtualNetworkCapacityException,
InsufficientAddressCapacityException;
+ String requestedIpv6) throws
InsufficientVirtualNetworkCapacityException,
InsufficientAddressCapacityException;
int getRuleCountForIp(Long addressId, FirewallRule.Purpose purpose,
FirewallRule.State state);
public String allocateGuestIP(Network network, String requestedIp) throws
InsufficientAddressCapacityException;
String allocatePublicIpForGuestNic(Network network, Long podId, Account
ipOwner, String requestedIp) throws InsufficientAddressCapacityException;
+ public AcquirePodIpCmdResponse allocatePodIp(String zoneId, String podId)
throws ConcurrentOperationException,
Review comment:
DONE. It was redundant. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
