fmaximus commented on a change in pull request #2193: CLOUDSTACK-10007
Isolation methods
URL: https://github.com/apache/cloudstack/pull/2193#discussion_r129040449
##########
File path:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
##########
@@ -133,7 +133,7 @@
public NuageVspGuestNetworkGuru() {
super();
- _isolationMethods = new IsolationMethod[] {IsolationMethod.VSP};
+ _isolationMethods = new IsolationMethod[] {new IsolationMethod("VSP")};
Review comment:
I would prefer defining the IsolationMethod as a constant instead, so we can
replace PhysicalNetwork.IsolationMethod.VSP.name() with
VSP_ISOLATION.getMethodPrefix()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
