wido opened a new pull request #2233: CLOUDSTACK-10042: Properly show ICMP 
SecGroup Rules
URL: https://github.com/apache/cloudstack/pull/2233
 
 
   A simple if-statement would fail if either the type or code were 0
   as that if-statement failed them.
   
   By checking if they are defined and casting them to a String afterwards
   this makes the if-statement properly resolve and show the rule as it should.
   
   Signed-off-by: Wido den Hollander <w...@widodh.nl>
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to