rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134771110
########## File path: api/src/org/apache/cloudstack/api/response/CertificateResponse.java ########## @@ -0,0 +1,58 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.cloudstack.api.response; + +import org.apache.cloudstack.api.ApiConstants; +import org.apache.cloudstack.api.BaseResponse; + +import com.cloud.serializer.Param; +import com.google.gson.annotations.SerializedName; + +public class CertificateResponse extends BaseResponse { + @SerializedName(ApiConstants.CERTIFICATE) + @Param(description = "The client certificate") + private String certificate = ""; + + @SerializedName(ApiConstants.PRIVATE_KEY) + @Param(description = "Private key for the certificate") + private String privateKey; + + @SerializedName(ApiConstants.CA_CERTIFICATES) + @Param(description = "The CA certificate(s)") + private String caCertificate; + + public CertificateResponse() { + setObjectName("certificates"); + } + + public CertificateResponse(final String objectName) { + setObjectName(objectName); + } + + public void setCertificate(final String certificate) { + this.certificate = certificate; + } + + public void setPrivateKey(final String privateKey) { Review comment: The response in this case is necessary, as the issue Cert is supposed to return private key when CSR is provided. The API is restricted to root-admin usage now, this is necessary. I'll see what I can do. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
