rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing
Agents Communications
URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134776690
##########
File path:
services/secondary-storage/controller/src/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java
##########
@@ -1118,7 +1119,7 @@ public boolean
finalizeVirtualMachineProfile(VirtualMachineProfile profile, Depl
StringBuilder buf = profile.getBootArgsBuilder();
buf.append(" template=domP type=secstorage");
- buf.append("
host=").append(ApiServiceConfiguration.ManagementHostIPAdr.value());
+ buf.append("
host=").append(StringUtils.shuffleCSVList(ApiServiceConfiguration.ManagementHostIPAdr.value()));
Review comment:
Yes, we want to have some randomness in case of multiple-mgmt server ips (if
configured) that's still better than a static/configured value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
