rhtyd commented on a change in pull request #2232: CLOUDSTACK-10040 Upload
volume fails when management server can not r?
URL: https://github.com/apache/cloudstack/pull/2232#discussion_r136425132
##########
File path: server/src/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -403,8 +415,11 @@ private boolean validateVolume(Account caller, long
ownerId, Long zoneId, String
throw new InvalidParameterValueException("File:// type urls
are currently unsupported");
}
UriUtils.validateUrl(format, url);
- // check URL existence
- UriUtils.checkUrlExistence(url);
+
+ // check URL existence
+ if(ValidateURLExistence.value()) {
Review comment:
I see some similar changes in https://github.com/apache/cloudstack/pull/2074
as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services