DaanHoogland commented on a change in pull request #2261: CLOUDSTACK-10068 -
Fixing test_iso.py assertions are equating srt and?
URL: https://github.com/apache/cloudstack/pull/2261#discussion_r137778352
##########
File path: test/integration/smoke/test_iso.py
##########
@@ -320,8 +320,8 @@ def test_02_edit_iso(self):
"Check display text of updated ISO"
)
self.assertEqual(
- iso_response.bootable,
- self.services["bootable"],
+ str(iso_response.bootable).lower(),
Review comment:
@borisstoyanov I am very worried the we are hiding issues this way. A test
that has been passing for about five years suddenly fails and then we fix the
test? I realize this *might* not be a issue with the code/system. Do we have
any clue as to when and why it started failing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
