rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After 
restarting cloudstack-management , It takes time to connect hosts
URL: https://github.com/apache/cloudstack/pull/2054#discussion_r138879356
 
 

 ##########
 File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
 ##########
 @@ -991,7 +995,9 @@ public boolean updateState(Status oldStatus, Event event, 
Status newStatus, Host
             }
         }
         if (event.equals(Event.ManagementServerDown)) {
-            ub.set(host, _pingTimeAttr, ((System.currentTimeMillis() >> 10) - 
(10 * 60)));
+            Float pingTimeout = 
NumbersUtil.parseFloat(_configDao.getValue("ping.timeout"), 2.5f);
 
 Review comment:
   @mrunalinikankariya please move towards using ConfigKeys, refactorings are 
requested.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to