mrunalinikankariya commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-330163316 Before fix (With 16 templates) 2017-09-18 18:19:52,830 DEBUG [c.c.a.ApiServlet] (qtp1538495109-12761:ctx-6a668556) (logid:330b3e52) ===START=== 10.11.100.115 -- GET command=listTemplates&listall=true&response=json&templatefilter=all 2017-09-18 18:19:52,944 DEBUG [c.c.a.ApiServlet] (qtp1538495109-12761:ctx-6a668556 ctx-9f9b539c) (logid:330b3e52) ===END=== 10.11.100.115 -- GET command=listTemplates&listall=true&response=json&templatefilter=all Total time to get list Template is : 944 - 830 = 1.14sec After fix (With 16 templates) 2017-09-18 19:25:55,574 DEBUG [c.c.a.ApiServlet] (qtp769172083-27:ctx-cca8c1d4) (logid:5b01e482) ===START=== 10.11.100.115 -- GET command=listTemplates&listall=true&response=json&templatefilter=all 2017-09-18 19:25:55,679 DEBUG [c.c.a.ApiServlet] (qtp769172083-27:ctx-cca8c1d4 ctx-fe269cc5) (logid:5b01e482) ===END=== 10.11.100.115 -- GET command=listTemplates&listall=true&response=json&templatefilter=all Total time to get list Template is : 679 ? 574 = 1.05 sec With only 16 templates, time difference is negligible. However we may get to see the improvement with bulk data. Test LGTM ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
