rhtyd commented on a change in pull request #2284: CLOUDSTACK-10103: Cloudian Connector for CloudStack URL: https://github.com/apache/cloudstack/pull/2284#discussion_r143161056
########## File path: plugins/integrations/cloudian/src/org/apache/cloudstack/cloudian/CloudianConnectorImpl.java ########## @@ -0,0 +1,345 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.cloudstack.cloudian; + +import java.security.KeyManagementException; +import java.security.KeyStoreException; +import java.security.NoSuchAlgorithmException; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; + +import javax.inject.Inject; +import javax.naming.ConfigurationException; + +import org.apache.cloudstack.acl.RoleType; +import org.apache.cloudstack.api.ApiErrorCode; +import org.apache.cloudstack.api.ServerApiException; +import org.apache.cloudstack.cloudian.api.CloudianIsEnabledCmd; +import org.apache.cloudstack.cloudian.api.CloudianSsoLoginCmd; +import org.apache.cloudstack.cloudian.client.CloudianClient; +import org.apache.cloudstack.cloudian.client.CloudianGroup; +import org.apache.cloudstack.cloudian.client.CloudianUser; +import org.apache.cloudstack.cloudian.client.CloudianUtils; +import org.apache.cloudstack.context.CallContext; +import org.apache.cloudstack.framework.config.ConfigKey; +import org.apache.cloudstack.framework.config.Configurable; +import org.apache.cloudstack.framework.messagebus.MessageBus; +import org.apache.cloudstack.framework.messagebus.MessageSubscriber; +import org.apache.log4j.Logger; + +import com.cloud.domain.Domain; +import com.cloud.domain.DomainVO; +import com.cloud.domain.dao.DomainDao; +import com.cloud.user.Account; +import com.cloud.user.AccountManager; +import com.cloud.user.DomainManager; +import com.cloud.user.User; +import com.cloud.user.dao.AccountDao; +import com.cloud.user.dao.UserDao; +import com.cloud.utils.component.ComponentLifecycleBase; +import com.cloud.utils.exception.CloudRuntimeException; + +public class CloudianConnectorImpl extends ComponentLifecycleBase implements CloudianConnector, Configurable { + private static final Logger LOG = Logger.getLogger(CloudianConnectorImpl.class); + + @Inject + private UserDao userDao; + + @Inject + private AccountDao accountDao; + + @Inject + private DomainDao domainDao; + + @Inject + private MessageBus messageBus; + + ///////////////////////////////////////////////////// + //////////////// Plugin Methods ///////////////////// + ///////////////////////////////////////////////////// + + private CloudianClient getClient() { + try { + return new CloudianClient(CloudianAdminHost.value(), CloudianAdminPort.value(), CloudianAdminProtocol.value(), + CloudianAdminUser.value(), CloudianAdminPassword.value(), + CloudianValidateSSLSecurity.value(), CloudianAdminApiRequestTimeout.value()); + } catch (final KeyStoreException | NoSuchAlgorithmException | KeyManagementException e) { + LOG.error("Failed to create Cloudian API client due to: ", e); + } + throw new CloudRuntimeException("Failed to create and return Cloudian API client instance"); + } + + private boolean addGroup(final Domain domain) { + if (domain == null || !isEnabled()) { + return false; + } + final CloudianClient client = getClient(); + final CloudianGroup group = new CloudianGroup(); + group.setGroupId(domain.getUuid()); + group.setGroupName(domain.getPath()); + group.setActive(true); + return client.addGroup(group); + } + + private boolean removeGroup(final Domain domain) { + if (domain == null || !isEnabled()) { + return false; + } + final CloudianClient client = getClient(); + for (final CloudianUser user: client.listUsers(domain.getUuid())) { + if (client.removeUser(user.getUserId(), domain.getUuid())) { + LOG.error(String.format("Failed to remove Cloudian user id=%s, while removing Cloudian group id=%s", user.getUserId(), domain.getUuid())); + } + } + for (int retry = 0; retry < 3; retry++) { + if (client.removeGroup(domain.getUuid())) { + return true; + } else { + LOG.warn("Failed to remove Cloudian group id=" + domain.getUuid() + ", retrying count=" + retry+1); + } + } + LOG.warn("Failed to remove Cloudian group id=" + domain.getUuid() + ", please remove manually"); + return false; + } + + private boolean addUserAccount(final Account account, final Domain domain) { + if (account == null || domain == null || !isEnabled()) { + return false; + } + final User accountUser = userDao.listByAccount(account.getId()).get(0); + final CloudianClient client = getClient(); + final String fullName = String.format("%s %s (%s)", accountUser.getFirstname(), accountUser.getLastname(), account.getAccountName()); + final CloudianUser user = new CloudianUser(); + user.setUserId(account.getUuid()); + user.setGroupId(domain.getUuid()); + user.setFullName(fullName); + user.setEmailAddr(accountUser.getEmail()); + user.setUserType(CloudianUser.USER); + user.setActive(true); + return client.addUser(user); + } + + private boolean updateUserAccount(final Account account, final Domain domain, final CloudianUser existingUser) { + if (account == null || domain == null || !isEnabled()) { + return false; + } + final CloudianClient client = getClient(); + if (existingUser != null) { + final User accountUser = userDao.listByAccount(account.getId()).get(0); + final String fullName = String.format("%s %s (%s)", accountUser.getFirstname(), accountUser.getLastname(), account.getAccountName()); Review comment: Good idea, however, we're using the `fullName` prior to comparison and we're only updating if there is any mismatch is fields, so we need to keep it here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
