rafaelweingartner commented on issue #2288: CLOUDSTACK-10107: For VMware VMs 
add devices without unit number
URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335476552
 
 
   @rhtyd may I ask you something? I was looking at the code, and I see that 
you removed a variable called `deviceNumber` that did not seem to be used at 
the method `prepareDvNicDevice`. However, looking at the changes I did not 
understand how they modify the limit of NICs to be attached into a VM when 
using VMware hypervisor. Is it related to that `setKey(30)` that you removed 
there?
   
   BTW: long time I am not able to review or work much with you guys ;)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to