DaanHoogland commented on a change in pull request #2290: WIP: add track id to
async api calls
URL: https://github.com/apache/cloudstack/pull/2290#discussion_r143742836
##########
File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
##########
@@ -333,6 +333,7 @@ public boolean getStartVm() {
} catch (NumberFormatException e) {
throw new InvalidParameterValueException("Unable to
translate and find entity with networkId: " + ips.get("networkid"));
}
+ // so no network found but a valid number as network id;
are we assuming exceptions thrown or lucky guessing?
Review comment:
I don't know yet, maybe an uncaught CloudRuntimeException is thrown
somewhere else, but you are right, we can throw it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
