DaanHoogland commented on a change in pull request #2290: WIP: add track id to
async api calls
URL: https://github.com/apache/cloudstack/pull/2290#discussion_r148765927
##########
File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
##########
@@ -333,6 +333,7 @@ public boolean getStartVm() {
} catch (NumberFormatException e) {
throw new InvalidParameterValueException("Unable to
translate and find entity with networkId: " + ips.get("networkid"));
}
+ // so no network found but a valid number as network id;
are we assuming exceptions thrown or lucky guessing?
Review comment:
sure, this comment should not add value any more once we decide how to
handle this case.
At this point we have not found a network but are having a networkId. I
think this should be unreachable.
I will refactor untill the code makes sense to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
