rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335689864 @rafaelweingartner thanks, good to see you reviewing. The issue is that during starting of a VM, we used hard coded nic unit numbers that caused the backend (vcenter side) to fail sometimes (well most the times, when number of nics > 7). I looked at the docs, and the unit number is not a mandatory attribute to use when adding new (nic) devices, which is the fix for the bug. In the specific method, we're still passing `deviceNumber` to be used as key when plugging in a dvswitch `nic` device, I removed the `setKey(30)` as `setKey` is again called, its usage is redundant and unnecessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
