rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New
network type (L2)
URL: https://github.com/apache/cloudstack/pull/2281#discussion_r144247839
##########
File path: server/src/com/cloud/network/IpAddressManagerImpl.java
##########
@@ -815,7 +814,7 @@ public IPAddressVO doInTransaction(TransactionStatus
status) throws Insufficient
}
addr.setState(assign ? IpAddress.State.Allocated :
IpAddress.State.Allocating);
- if (vlanUse != VlanType.DirectAttached) {
+ if (assign && vlanUse != VlanType.DirectAttached) {
Review comment:
Could this cause a backward compatibility issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
