rhtyd commented on a change in pull request #2281: CLOUDSTACK-10102: New 
network type (L2)
URL: https://github.com/apache/cloudstack/pull/2281#discussion_r144248053
 
 

 ##########
 File path: ui/scripts/configuration.js
 ##########
 @@ -2403,13 +2403,20 @@
                                         //*** VPC checkbox ***
                                         var $useVpc = 
args.$form.find('.form-item[rel=\"useVpc\"]');
                                         var $useVpcCb = 
$useVpc.find("input[type=checkbox]");
+                                        var $supportedServices = 
args.$form.find('.form-item[rel=\"supportedServices\"]');
                                         if ($guestTypeField.val() == 'Shared') 
{ //Shared network offering
                                             $useVpc.hide();
+                                            $supportedServices.css('display', 
'inline-block');
                                             if ($useVpcCb.is(':checked')) { 
//if useVpc is checked,
                                                 
$useVpcCb.removeAttr("checked"); //remove "checked" attribute in useVpc
                                             }
-                                        } else { //Isolated network offering
+                                        } else if ($guestTypeField.val() == 
'Isolated') { //Isolated network offering
                                             $useVpc.css('display', 
'inline-block');
+                                            $supportedServices.css('display', 
'inline-block');
+                                        }
+                                        else if ($guestTypeField.val() == 
'L2') {
 
 Review comment:
   Put `} else if ...` on same line as line 2413.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to