nvazquez commented on issue #2295: CLOUDSTACK-10109: Enable dedication of 
public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-336240972
 
 
   @borisstoyanov @rhtyd @DaanHoogland 
   
   Guys, one issue while porting this feature to 4.11 which was not present on 
4.6. In this commit: 
https://github.com/apache/cloudstack/commit/37301ed4540450c29be4f975d58b38dbeec6c296#diff-6adc687ad4a13d4b956fdc638299401b
 `domain_vlan_map` is introduced. When adding a new range on domain, a new 
entry on `domain_vlan_map` is created. As 
`IpAddressManagerImpl#fetchNewPublicIp` lists non dedicated zone wide vlans, 
but always returns range corresponding to vlan id = 1 (as there's no entry for 
it on domain_vlan_map) - check `ZoneWideNonDedicatedVlanSearch` search builder 
on `VlanDaoImpl`.
   What do you think will be the best solution for this case?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to