rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch
fixes and improvements
URL: https://github.com/apache/cloudstack/pull/2293#discussion_r146758445
##########
File path:
api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkCmdByAdmin.java
##########
@@ -48,6 +51,13 @@ public String getVlan() {
return vlan;
}
+ public Boolean getBypassVlanOverlapCheck() {
Review comment:
Yes, because cmd classes set API args to fields using reflections etc. It's
easier to not use native type `boolean`. When arg is not sent part of the API
request, it would be set to null; setting null to `boolean` will throw an
exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
