nitin-maharana commented on a change in pull request #2048: CLOUDSTACK-9880:
Expansion of Management IP Range.
URL: https://github.com/apache/cloudstack/pull/2048#discussion_r147090801
##########
File path: engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDao.java
##########
@@ -45,8 +45,11 @@
int countIPs(long dcId, boolean onlyCountAllocated);
+ int countIPs(String ipAddress, long podId, long dcId, boolean
onlyCountAllocated);
Review comment:
I had exactly the same thought to put everything in one method and pass null
values in not-needed parameters. But after looking at the usages of old
methods(ranges in pods/DCs), we have to make changes in many places. So, I
thought why not use the polymorphism concept to get rid of these many changes.
If the community agrees with these many changes, I will go ahead and coalesce
them to one method. Else we can always change the name of the current one
because now, it has only one usage. Either way, I am good. Please let me know
your opinion. Thanks!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
