nitin-maharana commented on a change in pull request #2048: CLOUDSTACK-9880: 
Expansion of Management IP Range.
URL: https://github.com/apache/cloudstack/pull/2048#discussion_r149804478
 
 

 ##########
 File path: api/src/org/apache/cloudstack/api/response/PodResponse.java
 ##########
 @@ -55,11 +55,11 @@
 
     @SerializedName("startip")
     @Param(description = "the starting IP for the Pod")
-    private String startIp;
+    private List<String> startIp;
 
 Review comment:
   As we are adding multiple ranges in a pod, so there will be a list of 
startIps and endIps. It is not breaking because if you look at the 
createPodResponse method of ApiResonseHelper, where the startIp and endIp 
variable are converted to list. And the Start IP and End IP field are removed 
from pod detail page. Hope this clarifies. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to