niteshsarda commented on issue #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag URL: https://github.com/apache/cloudstack/pull/905#issuecomment-340383809 Tested this fix and it seems to be working as per expectations. **LGTM for test.** Following are the results of the test cases that I have executed locally : Test Create tag on LB rule and remove the LB rule ... === TestName: test_01_lbrule_tag | Status : SUCCESS === ok Test Create tag on nat rule and remove the nat rule ... === TestName: test_02_natrule_tag | Status : SUCCESS === ok Test Create tag on firewall rule and remove the firewall rule ... === TestName: test_03_firewallrule_tag | Status : SUCCESS === ok Test Create tag on vpn and remove the vpn ... SKIP: VPN resource tags are unsupported in 4.0 Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status : SUCCESS === ok Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS === ok Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status : SUCCESS === ok Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status : SUCCESS === ok Test creation, listing and deletion tag son snapshot ... === TestName: test_09_snapshot_tag | Status : SUCCESS === ok Testcreation, listing and deletion tags on guest network ... === TestName: test_10_network_tag | Status : SUCCESS === ok Test migration of a tagged vm and delete the tag ... === TestName: test_11_migrate_tagged_vm_del | Status : SUCCESS === ok Test to verify that tags are not case sensitive ... === TestName: test_13_tag_case_insensitive | Status : SUCCESS === ok Test multiple tags and with special characters on same machine ... === TestName: test_14_special_char_mutiple_tags | Status : SUCCESS === ok Test creation, listing and deletion tags on projects ... === TestName: test_15_project_tag | Status : SUCCESS === ok Test Query the tags from other account ... === TestName: test_16_query_tags_other_account | Status : SUCCESS === ok Test Query the tags from admin account ... === TestName: test_17_query_tags_admin_account | Status : SUCCESS === ok Test listAPI with invalid tags parameter ... === TestName: test_18_invalid_list_parameters | Status : SUCCESS === ok Test deletion and addition of same tag on a resource. ... === TestName: test_19_delete_add_same_tag | Status : SUCCESS === ok Test creation of same tag on multiple resources ... === TestName: test_20_create_tags_multiple_resources | Status : SUCCESS === ok Test creation of tag on stopped vm. ... === TestName: test_21_create_tag_stopped_vm | Status : SUCCESS === ok Test creation of tag on stopped vm. ... === TestName: test_22_create_tag_destroyed_vm | Status : SUCCESS === ok Hosts without tag are not listed while listing the hosts for migration for instance with tag ... === TestName: test_23_list_untagged_host_for_vm_migration | Status : SUCCESS === ok Testcreation, adding and removing tag on public IP address ... === TestName: test_24_public_IP_tag | Status : SUCCESS === ok Testcreation, adding and removing tag on public IP address ... === TestName: test_25_IP_Address_tag | Status : SUCCESS === ok ---------------------------------------------------------------------- Ran 24 tests in 502.723s OK (SKIP=1)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
