DaanHoogland commented on a change in pull request #2270: CLOUDSTACK-10085 :
Upload volume from local fails when global config max.account.seconday.storage
is set to -1
URL: https://github.com/apache/cloudstack/pull/2270#discussion_r148721255
##########
File path:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
##########
@@ -2809,7 +2808,7 @@ private synchronized void
checkSecondaryStorageResourceLimit(TemplateOrVolumePos
int accountDirSizeInGB = getSizeInGB(accountTemplateDirSize +
accountSnapshotDirSize + accountVolumeDirSize);
int defaultMaxAccountSecondaryStorageInGB =
Integer.parseInt(cmd.getDefaultMaxAccountSecondaryStorage());
- if ((accountDirSizeInGB + contentLengthInGB) >
defaultMaxAccountSecondaryStorageInGB) {
+ if (defaultMaxAccountSecondaryStorageInGB !=
Resource.RESOURCE_UNLIMITED && (accountDirSizeInGB + contentLengthInGB) >
defaultMaxAccountSecondaryStorageInGB) {
Review comment:
I do agree with @rafaelweingartner to some extend but I don't think we
should stop this fix because of it. Also the extend is that I agree that
extracting the if in a separate method but that we should always try to not
need any comments (including javadoc)
I am merging this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
