rhtyd commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple 
Management Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#discussion_r149403249
 
 

 ##########
 File path: agent/src/com/cloud/agent/AgentShell.java
 ##########
 @@ -173,6 +194,19 @@ public void setPersistentProperty(String prefix, String 
name, String value) {
             _storage.persist(name, value);
     }
 
+    @Override
+    public boolean setPropertyAndPersist(String property, String value) {
 
 Review comment:
   Don't use it, there is another way to do that --> call 
setPersistentProperty, see the method is just above your implementation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to