anshul1886 commented on a change in pull request #2315: A comprehensive
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r150201653
##########
File path: engine/schema/src/com/cloud/host/dao/HostDao.java
##########
@@ -103,4 +95,13 @@
List<HostVO> listByType(Type type);
HostVO findByIp(String ip);
+
+ /**
+ * This method will look for a host that is connected to the storage pool
where the volume of the Snapshot is stored.
+ * <ul>
+ * <li>If the storage pool found for the volume of the snapshotId has more
than a host, we will choose one randomly;
+ * <li>If no host is found, we throw a runtime exception
+ * </ul>
+ */
+ HostVO findHostConnectedToSnapshotStoragePoolToExecuteCommand(long
snapshotId);
Review comment:
Command only goes to SSVM when only secondary storage is involved so no role
of storage pool here so better to think of some other way to find host. VMware
also needs random host for similar kind of operation so need to think including
that in mind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
