anshul1886 commented on a change in pull request #2315: A comprehensive 
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r151090305
 
 

 ##########
 File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
 ##########
 @@ -1194,4 +1178,26 @@ public HostVO findByIp(final String ipAddress) {
         sc.setParameters("type", type);
         return listBy(sc);
     }
-}
+
+    String sqlFindHostConnectedToSnapshotStoragePoolToExecuteCommand = "select 
h.id from snapshots s join volumes v on v.id = s.volume_id "
+            + "join storage_pool pool on pool.id = v.pool_id join cluster c on 
pool.cluster_id = c.id join host h on h.cluster_id = c.id "
 
 Review comment:
   Yes, we only use secondary storage to build the template from snapshot. This 
might not be applicable to managed store. But that's also available to all 
hosts in zone so any random host in a zone will do.
   
   Also we can delete volume without deleting its snapshot (backup). We only 
delete VM snapshots when we delete VM.
   
   Yes I meant using JPA queries.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to