rhtyd commented on a change in pull request #2327: CLOUDSTACK-10129: Show
account, network info in VR list view
URL: https://github.com/apache/cloudstack/pull/2327#discussion_r151388752
##########
File path: ui/scripts/system.js
##########
@@ -29,9 +29,19 @@
var mapRouterType = function (index, router) {
var routerType = _l('label.menu.system');
- if (router.projectid) routerType = _l('label.project');
- if (router.vpcid) routerType = _l('label.vpc');
- if ("isredundantrouter" in router && router.isredundantrouter)
routerType = routerType + " (" + router.redundantstate + ")";
+ if (router.projectid) {
+ routerType = _l('label.project');
+ router.account = router.project;
+ }
+
+ if (router.vpcid) {
+ routerType = _l('label.vpc');
+ router.guestnetworkname = router.vpcname;
+ }
+
+ if ("isredundantrouter" in router && router.isredundantrouter) {
Review comment:
Thanks, I get defensive writing code. I guess this is not be necessary here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
