rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r152253028
##########
File path: systemvm/patches/debian/config/opt/cloud/bin/configure.py
##########
@@ -172,8 +172,13 @@ def add_rule(self):
logging.debug("egress rule ####==> %s", self.rule)
for cidr in self.rule['dcidr']:
- ipsetAddCmd = 'ipset add '+ destIpsetName + ' '+cidr
- CsHelper.execute(ipsetAddCmd)
+ # Bug reference:
https://bugzilla.redhat.com/show_bug.cgi?id=1297092
+ if cidr == '0.0.0.0/0':
+ CsHelper.execute('ipset add '+ destIpsetName + '
0.0.0.0/1')
+ CsHelper.execute('ipset add '+ destIpsetName + '
128.0.0.0/1')
+ else:
+ ipsetAddCmd = 'ipset add '+ destIpsetName + ' ' + cidr
+ CsHelper.execute(ipsetAddCmd)
dflag = True
Review comment:
@NuxRo FYI - I've fixed the egress 0.0.0.0/0 issue in this branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
