rhtyd commented on a change in pull request #2333: Add Java Default Certificat
Authorities into the keystore if using a custom cert SSL
URL: https://github.com/apache/cloudstack/pull/2333#discussion_r152482777
##########
File path: systemvm/scripts/config_ssl.sh
##########
@@ -120,7 +120,7 @@ customCACert=
publicIp=
hostName=
keyStore=$(dirname $0)/certs/realhostip.keystore
-defaultJavaKeyStoreFile=/etc/ssl/certs/java/cacerts
+defaultJavaKeyStoreFile="$(jrunscript -e
'java.lang.System.out.println(java.lang.System.getProperty("java.home"));')/lib/security/cacerts"
Review comment:
LGTM for 4.10, however for 4.11 we're going back to openjdk-8 provided in
Debian "Stretch" where this may not be needed. Maybe you want to send this PR
for 4.10?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
