rafaelweingartner commented on a change in pull request #2340: 
CLOUDSTACK-10106: GPU/vGPU Support on VMWare
URL: https://github.com/apache/cloudstack/pull/2340#discussion_r153313332
 
 

 ##########
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##########
 @@ -3348,9 +3404,35 @@ protected Answer execute(StopCommand cmd) {
         // i.e., i-x-y. This is the internal VM name.
         VmwareContext context = getServiceContext();
         VmwareHypervisorHost hyperHost = getHyperHost(context);
+
         try {
             VirtualMachineMO vmMo = 
hyperHost.findVmOnHyperHost(cmd.getVmName());
+
             if (vmMo != null) {
 
 Review comment:
   What about extracting this code from 3411-3429 to a method? It might also be 
good to Document it, and write some unit test cases

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to