This is an automated email from the ASF dual-hosted git repository.
bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new ed6e3be CLOUDSTACK-7793: Create Snaphot with quiesce option set to
true fails with InvalidParameterValueException (#2312)
ed6e3be is described below
commit ed6e3be756f9f292d5a38fc24ce90e798e066371
Author: subhash yedugundla <[email protected]>
AuthorDate: Fri Dec 1 02:43:39 2017 +0530
CLOUDSTACK-7793: Create Snaphot with quiesce option set to true fails with
InvalidParameterValueException (#2312)
reate Snaphot with quiesce option set to true fails with
InvalidParameterValueException
--quiescevm option is only supported with netapp plugin with vmware. When
netapp is not there, they would be struck in Allocated state and Deletion is
not supported in allocated state. To fix this issue, deletion is supported in
allocated state as well.
---
server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
b/server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
index a84db08..bd42fac 100644
--- a/server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
+++ b/server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
@@ -18,6 +18,7 @@
package com.cloud.vm.snapshot;
import java.util.ArrayList;
+import java.util.Arrays;
import java.util.Date;
import java.util.HashMap;
import java.util.List;
@@ -603,9 +604,10 @@ public class VMSnapshotManagerImpl extends
MutualExclusiveIdsManagerBase impleme
_accountMgr.checkAccess(caller, null, true, vmSnapshot);
- // check VM snapshot states, only allow to delete vm snapshots in
created and error state
- if (VMSnapshot.State.Ready != vmSnapshot.getState() &&
VMSnapshot.State.Expunging != vmSnapshot.getState() && VMSnapshot.State.Error
!= vmSnapshot.getState()) {
- throw new InvalidParameterValueException("Can't delete the vm
snapshotshot " + vmSnapshotId + " due to it is not in Created or Error, or
Expunging State");
+ List<VMSnapshot.State> validStates =
Arrays.asList(VMSnapshot.State.Ready, VMSnapshot.State.Expunging,
VMSnapshot.State.Error, VMSnapshot.State.Allocated);
+ // check VM snapshot states, only allow to delete vm snapshots in
ready, expunging, allocated and error state
+ if (!validStates.contains(vmSnapshot.getState())) {
+ throw new InvalidParameterValueException("Can't delete the vm
snapshot " + vmSnapshotId + " due to it is not in " + validStates.toString() +
"States");
}
// check if there are other active VM snapshot tasks
--
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].
