niteshsarda commented on a change in pull request #2361:
CLOUDSTACK-10190:Duplicate public VLAN for two different admin accounts.
URL: https://github.com/apache/cloudstack/pull/2361#discussion_r157177627
##########
File path: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -2859,35 +2859,42 @@ public Vlan createVlanAndPublicIpRange(final
CreateVlanIpRangeCmd cmd) throws In
private Vlan commitVlan(final Long zoneId, final Long podId, final String
startIP, final String endIP, final String newVlanGatewayFinal, final String
newVlanNetmaskFinal,
final String vlanId, final Boolean forVirtualNetwork, final Long
networkId, final Long physicalNetworkId, final String startIPv6, final String
endIPv6,
final String ip6Gateway, final String ip6Cidr, final Domain
domain, final Account vlanOwner, final Network network, final Pair<Boolean,
Pair<String, String>> sameSubnet) {
- return Transaction.execute(new TransactionCallback<Vlan>() {
- @Override
- public Vlan doInTransaction(final TransactionStatus status) {
- String newVlanNetmask = newVlanNetmaskFinal;
- String newVlanGateway = newVlanGatewayFinal;
+ final GlobalLock commitVlanLock =
GlobalLock.getInternLock("CommitVlan");
+ commitVlanLock.lock(5);
+ s_logger.debug("Acquiring lock for committing vlan");
+ try {
Review comment:
Below is an existing code, changes can be seen due to addition of spaces for
doing proper alignment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
