This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 44a7eb0 CLOUDSTACK-10176: VM Start Api Job returns success for failed
Job (#2354)
44a7eb0 is described below
commit 44a7eb0d141564ac6f9d827ce1f460b9cbd653c0
Author: niteshsarda <[email protected]>
AuthorDate: Fri Dec 15 17:18:51 2017 +0530
CLOUDSTACK-10176: VM Start Api Job returns success for failed Job (#2354)
ISSUE :
VM start API Job returns success for failed Job
STEPS TO REPRODUCE :
Stop VM instance.
Mark state of associate router as Stopping from DB
Execute startVirtualMachine Api from rest client.
VM will not start but still main job will return the status as SUCCEEDED,
whereas sub-job for command VmWorkStart will return status as failed.
---
.../orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
index fe7fcdf..74927b9 100755
--- a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
+++ b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -38,6 +38,7 @@ import java.util.concurrent.TimeUnit;
import javax.inject.Inject;
import javax.naming.ConfigurationException;
+import org.apache.cloudstack.framework.jobs.impl.JobSerializerHelper;
import com.cloud.agent.api.AttachOrDettachConfigDriveCommand;
import org.apache.cloudstack.affinity.dao.AffinityGroupVMMapDao;
import org.apache.cloudstack.ca.CAManager;
@@ -4730,8 +4731,9 @@ public class VirtualMachineManagerImpl extends
ManagerBase implements VirtualMac
orchestrateStart(vm.getUuid(), work.getParams(), work.getPlan(),
_dpMgr.getDeploymentPlannerByName(work.getDeploymentPlanner()));
}
catch (CloudRuntimeException e){
- s_logger.info("Caught CloudRuntimeException, returning job
failed");
- return new Pair<JobInfo.Status, String>(JobInfo.Status.FAILED,
null);
+ s_logger.info("Caught CloudRuntimeException, returning job failed
" + e);
+ CloudRuntimeException ex = new CloudRuntimeException("Unable to
start VM instance");
+ return new Pair<JobInfo.Status, String>(JobInfo.Status.FAILED,
JobSerializerHelper.toObjectSerializedString(ex));
}
return new Pair<JobInfo.Status, String>(JobInfo.Status.SUCCEEDED,
null);
}
--
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].
