priyankparihar commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-352337959 Hi @rhtyd >user should not be provided the option to specify root volume (in UI) for VMware when vmware.create.full.clone is false. Good point. LGTM >On the backend side, this check should be made before determining whether to throw an exception (i.e. disk chain length > 1 and the global setting is true) or skip with a warning (when the global setting it false). Not LGTM. Size check is already present. I think, if someone is asking for X then we should not give Y(with some warning). Please correct me if i am saying something wrong.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
