rhtyd commented on a change in pull request #1762: CLOUDSTACK-9595 Transactions
are not getting retried in case of datab?
URL: https://github.com/apache/cloudstack/pull/1762#discussion_r157970919
##########
File path: server/src/com/cloud/network/IpAddressManagerImpl.java
##########
@@ -901,40 +916,28 @@ public PublicIp assignDedicateIpAddress(Account owner,
final Long guestNtwkId, f
PublicIp ip = null;
try {
- ip = Transaction.execute(new
TransactionCallbackWithException<PublicIp,
InsufficientAddressCapacityException>() {
Review comment:
@yvsubhash I've found a regression with changes to this method. It causes
SNAT IPs to not get allocated and we see something like this:
```
2017-12-20 14:32:40,402 ERROR [c.c.n.IpAddressManagerImpl]
(API-Job-Executor-16:ctx-d4229b63 job-418 ctx-da9f0f88) (logid:8f31a2f6) Unable
to get source nat ip address for account 2
```
This causes VPC/VPN tests to fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
