rhtyd commented on a change in pull request #1762: CLOUDSTACK-9595 Transactions
are not getting retried in case of datab?
URL: https://github.com/apache/cloudstack/pull/1762#discussion_r158486498
##########
File path: server/src/com/cloud/network/IpAddressManagerImpl.java
##########
@@ -759,7 +761,7 @@ public IPAddressVO doInTransaction(TransactionStatus
status) throws Insufficient
Filter filter = new Filter(IPAddressVO.class, "vlanId", true,
0l, 1l);
- List<IPAddressVO> addrs = _ipAddressDao.lockRows(sc, filter,
true);
+ List<IPAddressVO> addrs = _ipAddressDao.search(sc, filter,
false);
Review comment:
The issue seems to be here where search happens without no locks and other
threads may end up getting the same list of non-free ip addresses to allocate
address from.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
