rhtyd commented on a change in pull request #2244: CLOUDSTACK-10054:Volume
download times out in 3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#discussion_r158674726
##########
File path:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java
##########
@@ -42,6 +44,9 @@
static final ConfigKey<String> s_vmwareSearchExcludeFolder = new
ConfigKey<String>("Advanced", String.class, "vmware.search.exclude.folders",
null,
"Comma seperated list of Datastore Folders to exclude from VMWare
search", true, ConfigKey.Scope.Global);
+ static final ConfigKey<Integer> s_vmwareOVAPackageTimeout = new
ConfigKey<Integer>(Integer.class, "vmware.package.ova.timeout",
"Advanced",String.valueOf(VM_OVA_PACKAGE_TIMEOUT_SEC),
Review comment:
@mrunalinikankariya see ` "Advanced",String.valueOf` would look better as `
"Advanced", String.valueOf` this is what I meant by fixing the space.
The constant are default values for the ConfigKey, and not used anywhere
else. ConfigKey defaul values are themselves treated as well `defaults`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
