rhtyd commented on a change in pull request #2244: CLOUDSTACK-10054:Volume 
download times out in 3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#discussion_r158674795
 
 

 ##########
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ##########
 @@ -98,28 +98,31 @@
     @Override
     public boolean execute(VmwareHostService hostService, 
CreateEntityDownloadURLCommand cmd) {
         DataTO data = cmd.getData();
+        int timeout = 
NumbersUtil.parseInt(cmd.getContextParam(VmwareManager.s_vmwareOVAPackageTimeout.key()),
 VmwareManagerImpl.DEFAULT_VM_OVA_PACKAGE_TIMEOUT);
 
 Review comment:
   @mrunalinikankariya you can get a `default()` from a ConfigKey, just like 
you did with the `key()`. This won't read the value from the db.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to