DaanHoogland commented on a change in pull request #2382: CLOUDSTACK-4045 
URL: https://github.com/apache/cloudstack/pull/2382#discussion_r159233140
 
 

 ##########
 File path: server/src/com/cloud/network/IpAddressManagerImpl.java
 ##########
 @@ -1394,6 +1380,25 @@ public IPAddressVO associateIPToGuestNetwork(long ipId, 
long networkId, boolean
         }
     }
 
+    protected boolean isSourceNatAvailableForNetwork(long networkId, Account 
owner, IPAddressVO ipToAssoc, Network network) {
 
 Review comment:
   is networkId needed on this signature? network is being passed as well!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to