rafaelweingartner commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355102557 It is not only comments related to generic catches... There are a few others, for instance, there is one regarding cyclomatic complexity in OVFHelper.java. Then, in the same class a question regarding the excessive manual parse of XML (Some tool to do this might be better, there are a bunch of different ones that can be used for this). In DeployVMCmd.java there is also something else regarding cyclomatic complexity. There is also the issue of magic numbers and the suggestion to create a utils class to convert between bases (MiB, MB, KB, and so on....). In summary, there are few others issues besides the catches... If you guys want to push this in the way it is I cannot do much; I normally do not give -1 (I did not give a -1 here), unless it is something very bad. I normally conduct discussions on standard and quality of the code. The idea is to show people that code can and should always be improved.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
