DaanHoogland commented on a change in pull request #2282:
CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve
performance
URL: https://github.com/apache/cloudstack/pull/2282#discussion_r159821175
##########
File path: server/src/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1890,8 +1890,7 @@
respView = ResponseView.Full;
}
- List<DomainResponse> domainResponses =
ViewResponseHelper.createDomainResponse(respView, cmd.getDetails(),
result.first().toArray(
- new DomainJoinVO[result.first().size()]));
+ List<DomainResponse> domainResponses =
ViewResponseHelper.createDomainResponse(respView, cmd.getDetails(),
result.first());
Review comment:
aren't we changing the API semantics here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
