rhtyd commented on a change in pull request #2271: CLOUDSTACK-10087 Template 
registration errors out when template URL i?
URL: https://github.com/apache/cloudstack/pull/2271#discussion_r159943124
 
 

 ##########
 File path: systemvm/debian/opt/cloud/bin/setup/secstorage.sh
 ##########
 @@ -80,10 +80,22 @@ CORS
   rm -f /etc/logrotate.d/cloud
 }
 
+import_jvm_cacerts(){
+ log_it "importing jvm keystore to realhostip keystore"
+ keyStore=/usr/local/cloud/systemvm/certs/realhostip.keystore
+ storepass="vmops.com"
+ java_home=$(readlink -f $(which java) | sed "s:/bin/java::")
+ java_keystore=$java_home/jre/lib/security/cacerts
 
 Review comment:
   Tested manually, the keystore path should be 
`$java_home/lib/security/cacerts` for 4.11/debian9 based systemvmtemplate. 
Also, consider using upper case variables such as `JAVA_HOME`, `JAVA_KEYSTORE` 
etc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to