fmaximus commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813:
Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160403836
##########
File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
##########
@@ -281,6 +283,13 @@ public Long getTemplateId() {
}
public String getUserData() {
+ if (userData != null) {
+ try {
+ userData = URLDecoder.decode(userData, "UTF-8");
Review comment:
The UI sends the userdata UrlEncoded.
But you're correct that this shouldn't happen if the userdata isn't URL
encoded in the first place.
I'm going to move the code to UserVmManagerImpl.validateUserData(),
and only to the URL decode if the userdata contains %
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
