rhtyd commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813:
Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160524430
##########
File path: tools/marvin/marvin/config/test_data.py
##########
@@ -513,6 +565,19 @@
"NetworkACL": 'VpcVirtualRouter'
}
},
+ "vpc_offering_configdrive": {
+ "name": 'VPC offering ConfigDrive',
+ "displaytext": 'VPC offering ConfigDrive',
+ "supportedservices":
'Dhcp,StaticNat,SourceNat,NetworkACL,UserData,Dns',
+ "serviceProviderList": {
+ "Dhcp": "VpcVirtualRouter",
+ "StaticNat": "VpcVirtualRouter",
+ "SourceNat": "VpcVirtualRouter",
+ "NetworkACL": "VpcVirtualRouter",
+ "UserData": "ConfigDrive",
+ "Dns": "VpcVirtualRouter"
+ }
+ },
Review comment:
Yes, the test dsta should not be part of marvin library at all. We should
stop doing that at least with new tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
