rafaelweingartner commented on a change in pull request #2398:
CLOUDSTACK-10222: Clean previous snaphosts from primary storage when ?
URL: https://github.com/apache/cloudstack/pull/2398#discussion_r160629183
##########
File path:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
##########
@@ -559,12 +559,12 @@ public Answer backupSnapshot(final CopyCommand cmd) {
physicalSize = Long.parseLong(tmp[1]);
finalPath = folder + File.separator + snapshotBackupUuid +
".vhd";
}
-
- final String volumeUuid = snapshotTO.getVolume().getPath();
Review comment:
This is where I was getting confused. I am inspecting the code in master,
and we were only removing other snapshots, but the last one when it was not a
full clone. You changed so we remove all but the last one always.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
