mike-tutkowski commented on issue #2416: CLOUDSTACK-10244: KVM online storage migration fails URL: https://github.com/apache/cloudstack/pull/2416#issuecomment-359183045 From dev@: Perhaps your argument against the final keyword is that it should never be used? If so, you and @wido can debate that and let me know which way you?d like this bit of code to end up. On Jan 20, 2018, at 9:05 AM, Tutkowski, Mike <[email protected]> wrote: It?s pretty much the reason why the final variable exists in Java: to make a variable a constant so no one accidentally changes it. @wido just wanted the code to protect against the variable being changed...that?s all. On Jan 20, 2018, at 8:25 AM, Rafael Weing?rtner <[email protected]> wrote: Changed by a future programmer that may develop some changes in your code? Because, if you do not code any other assignment to that variable, it will never happen. On Sat, Jan 20, 2018 at 1:16 PM, Tutkowski, Mike <[email protected]> wrote: @wido just wanted to make sure the Boolean variable didn?t accidentally get changed later since it?s critical it keep that value. On Jan 20, 2018, at 8:14 AM, Tutkowski, Mike <[email protected]> wrote: I made it final per @wido?s comment (in #2415). How?s about you guys hash it out and get back to me. :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
